[Core] A little refactoring of loadcanvas.cpp #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodolforg
requested changes
Jan 3, 2021
| @@ -2284,6 +2284,13 @@ CanvasParser::parse_static_list(xmlpp::Element *element,Canvas::Handle canvas) | |||
| return value_node; | |||
| } | |||
|
|
|||
| bool read_bool_attribute(xmlpp::Element* element, const char* name) { | |||
There was a problem hiding this comment.
-
prepend
static -
Maybe rename to
is_bool_attribute_true()orevaluate_bool_attribute()
When I readif (read_bool_attribute)I have the impression I'm checking if it could read the attribute, not exactly evaluating its value.
There was a problem hiding this comment.
I have the impression I'm checking if it could read the attribute
This is the correct impression, because it tries to read the attribute and returns false if it cannot read it (for example, the attribute was not found).
Maybe rename to is_bool_attribute_true()
Agree. This is more correct.
ice0
force-pushed
the
loadcanvs-cleanup
branch
2 times, most recently
from
5bb2376 to
4b97318
Compare
ice0
force-pushed
the
loadcanvs-cleanup
branch
from
4b97318 to
ada51af
Compare
rodolforg
pushed a commit
to rodolforg/synfig
that referenced
this pull request
May 26, 2021
rodolforg
pushed a commit
to rodolforg/synfig
that referenced
this pull request
May 26, 2021
rodolforg
pushed a commit
to rodolforg/synfig
that referenced
this pull request
May 27, 2021
morevnaproject
pushed a commit
that referenced
this pull request
Jul 12, 2021
morevnaproject
pushed a commit
to morevnaproject/synfig
that referenced
this pull request
Aug 9, 2021
morevnaproject
pushed a commit
to morevnaproject/synfig
that referenced
this pull request
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of this PR (#1955)