Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for X/Y position before Z probe #119

Open
rsteckler opened this issue May 31, 2023 · 3 comments
Open

Add support for X/Y position before Z probe #119

rsteckler opened this issue May 31, 2023 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@rsteckler
Copy link

My shapeoko (and I'm assuming pin 5 GPIO devices) have the z probe detector at a specific location. It would be great if the z-probe feature would auto-locate to that X/Y position before plunging. I'm guessing two new settings: Zprobe X position and Zprobe Y position.

Love the plugin. Thank you so much for supporting it!

@paukstelis
Copy link
Contributor

paukstelis commented Jul 19, 2023

I happened to be looking at probing when I saw this issue, so I took a whack at it. Not tested! Values are mm to jog (relative) before Z probing (should compensate for frame position). https://github.com/paukstelis/Octoprint-Bettergrblsupport/tree/xy_on_zprobe

@synman
Copy link
Owner

synman commented Oct 5, 2023

Hey @paukstelis ... not sure how far your fork has diverged, but I'm more than happy to take this as a PR.

Yeah, I know... 3 months to respond. I've been busy doing nothing else in particular these past few months.

@synman synman added the enhancement New feature or request label Oct 5, 2023
@paukstelis
Copy link
Contributor

Honestly, I barely even remember this 😄 . I know I have never tested it, which makes me somewhat hesitant to submit a PR, but if someone is willing to try it out I can.

@synman synman added this to the 2.3.2 milestone Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants