Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: kratix-cli github release should include compiled binary #72

Open
ChunyiLyu opened this issue Jan 27, 2025 · 3 comments
Open

bug: kratix-cli github release should include compiled binary #72

ChunyiLyu opened this issue Jan 27, 2025 · 3 comments
Assignees

Comments

@ChunyiLyu
Copy link
Member

Context

Two issues reported by @abangser should be addressed as part of this:

  1. v0.3.0 doesn’t seem to have the --version flag anymore (I built locally and couldn’t get version)
❯ kratix --version
Error: unknown flag: --version
Usage:
  kratix [command]

Same behavior confirmed on latest main.

We are now releasing with goreleaser, information about version could come from goreleaser instead of a fixed value.

  1. We don’t have binaries in the release any more: https://github.com/syntasso/kratix-cli/releases

Binaries are there for 0.1.0 and 0.2.0. After we start releasing as a go package, binaries weren't uploaded anymore. fix it

@ChunyiLyu ChunyiLyu self-assigned this Jan 27, 2025
@ChunyiLyu
Copy link
Member Author

The 0.3.0 release job actually failed: https://app.circleci.com/pipelines/github/syntasso/kratix-cli/218/workflows/f9b95f5d-0ca4-4b5f-b539-53f9538af595/jobs/437

and that explains the lack of binaries in release artifact. Investigating

@ChunyiLyu
Copy link
Member Author

Should be fixed by PR: #73

Will merge and cut 0.4.0 to test

@ChunyiLyu
Copy link
Member Author

ChunyiLyu commented Jan 27, 2025

0.4.0 is cut and compiled binaries are uploaded to release artifacts: https://github.com/syntasso/kratix-cli/releases/tag/v0.4.0

If you download these binaries, and run

❯ ~/Downloads/kratix-cli_Darwin_arm64/kratix --version
kratix version 0.4.0-SNAPSHOT-4ab24a2

you have version information.

However if you compile the dev version, or install with go install, version information is unavailable. I think this is due to the fact that we expect version to be set by go releaser at release but go install installs the CLI at specific git tag not through an artifact built by go releaser.

Going to pause working on this issue and check in in standup tomorrow to see if we need to fix this. Users are recommended to install the CLI via github release binaries anyways in our docs: https://docs.kratix.io/main/kratix-cli/intro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant