-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Player needs a way to be opened after it's been closed #1195
Comments
Can we get a hotkey? 👀 |
Ooo yah, what should the key be? |
I dunno, maybe Here's the list of shortcuts YouTube supports. They use Hitting the |
'p' for us screen reader users jumps to the next paragraph and reads it. Single key hotkeys are mostly taken up by screen reader manufacturers. Kind of a bummer and a pain, I know.
I can "pass a key through to the application/browser, but that can provide UX issues for those of us who need to use assistive technologies to equitably access browser functionality.
Best,
David
|
I think this issue needs to be in three parts:
|
I'm really keen to help out with this 🙋🏽♂️ I converted my hotkey PR to a draft for now - I think I could maybe tackle part 1 & 3 with some guidance on what you would want the shortcuts to be/do. Also, perhaps a part 4 would be having some UI that shows you what shortcuts are available? |
Awesome, yes would love the help! Some guidance:
state.audio?.pause(); // pause it
|
This has been fixed with a minimized player and closing player resetting the player. |
right now if you close the player, it keeps playing, but there isn't a way to get it back open unless you click play on the audio again.
Would be nice for it to minimize into just the show title / 1 line high
The text was updated successfully, but these errors were encountered: