Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation sampler interpolation mode in docs doesn't exist in glTF 2.0 specifications #166

Closed
Ybalrid opened this issue May 15, 2019 · 3 comments

Comments

@Ybalrid
Copy link
Contributor

Ybalrid commented May 15, 2019

Consider the comments here: https://github.com/syoyo/tinygltf/blob/master/tiny_gltf.h#L440

The interpolation mode CATMULLROMSPLINE is not part of the glTF specification. By loading a standard glTF the AnimationSampler::interpolation string will never be equals to CATMULLROMSPLINE.

glTF 2.0 : https://github.com/KhronosGroup/glTF/tree/master/specification/2.0?ts=4#animations (3rd paragraph after the JSON codeblock)

Interpolation between keys is performed using the interpolation method specified in the interpolation property. Supported interpolation values include LINEAR, STEP, and CUBICSPLINE

This information should be removed from the list.

If that interpolation mode is provided by an extension, it should be provided as an extension value anyway...

@syoyo
Copy link
Owner

syoyo commented May 15, 2019

Thanks! After glimpsed glTF git repo and github issues, CATMULLROMSPLINE was exist in glTF 2.0 beta phase(? when I started to working on the parser for glTF 2.0) but removed in the final glTF 2.0 spec.

KhronosGroup/glTF#605 (comment)

So, yes, I will remove CATMULLROMSPLINE soon.

@Ybalrid
Copy link
Contributor Author

Ybalrid commented May 15, 2019

exist in glTF 2.0 beta phase

Okay, so that's why. It's just a comment message anyway, I think tinygltf just pulls the content of the string inside the JSON object.

It's just a matter to keep the comments that serve as documenting the data in accordance to the specification. 🙂

@syoyo
Copy link
Owner

syoyo commented May 16, 2019

Removed https://github.com/syoyo/tinygltf/commit/fbc429577031f29f1fa0a93503ae1438fc8c918e by this commit: fbc4295

@syoyo syoyo closed this as completed May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants