Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit how long Purchased From and Sold To can be #232

Closed
6 tasks done
tonyaellie opened this issue Sep 17, 2024 · 4 comments
Closed
6 tasks done

Limit how long Purchased From and Sold To can be #232

tonyaellie opened this issue Sep 17, 2024 · 4 comments
Labels
🕷️ bug Something isn't working good first issue Good for newcomers 👷‍♂️ help wanted Extra attention is needed

Comments

@tonyaellie
Copy link
Collaborator

First Check

  • This is not a feature request
  • I added a very descriptive title to this issue.
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the documentation, with the integrated search.
  • I already read the docs and didn't find an answer.
  • I can replicate the issue inside the Demo install.

Homebox Version

v0.14.1

What is the issue you are experiencing?

image

There is no limit to how long purchased from and sold to can be.

Should prob have a limit of 255 or 1k like most other fields

How can the maintainer reproduce the issue?

  1. Create an item.
  2. Go to the edit page and put in text.
  3. Watch in amazement as it will let you save text of seemingly any length (at least up to 1mil chars).

Deployment

Docker (Linux)

OS Architechture

x86_64 (AMD, Intel)

Deployment Details

No response

@tonyaellie tonyaellie added the 🕷️ bug Something isn't working label Sep 17, 2024
@101br03k
Copy link
Contributor

To be fair, I see this as a feature not a bug, unless you did find any problems with Homebox after inserting and saving 1mil chars?

@tonyaellie
Copy link
Collaborator Author

Mainly just made the page very laggy and didn't wrap so the page was very wide.

@tankerkiller125
Copy link
Contributor

We could make the text wrap, however, large text does have issues both with being rendered (after all it is a frontend JS Framework), and on top of that, if we ever do any form of search/indexing on those fields it would slow down search significantly.

@tonyaellie
Copy link
Collaborator Author

Also we do limit the length of basically every other text field seems weird to not limit these two.

@katosdev katosdev added good first issue Good for newcomers 👷‍♂️ help wanted Extra attention is needed labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕷️ bug Something isn't working good first issue Good for newcomers 👷‍♂️ help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants