Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hope to support Simplified Chinese #32

Closed
1 of 3 tasks
Q-1515 opened this issue Jun 20, 2024 · 6 comments · Fixed by #155
Closed
1 of 3 tasks

Hope to support Simplified Chinese #32

Q-1515 opened this issue Jun 20, 2024 · 6 comments · Fixed by #155
Labels
⬆️ enhancement New feature or request good first issue Good for newcomers 👷‍♂️ help wanted Extra attention is needed

Comments

@Q-1515
Copy link

Q-1515 commented Jun 20, 2024

What is the problem you are trying to solve with this feature?

This application is very helpful to me, but it is not convenient for other users to read

What is the solution you are proposing?

No response

What alternatives have you considered?

No response

Additional context

No response

Contributions

  • I have searched through existing issues and feature requests to see if my idea has already been proposed.
  • If this feature is accepted, I would be willing to help implement and maintain this feature.
  • If this feature is accepted, I'm willing to sponsor the development of this feature.
@Q-1515 Q-1515 added the ⬆️ enhancement New feature or request label Jun 20, 2024
@tankerkiller125
Copy link
Contributor

I haven't gotten too deep into the code, so I haven't dug into any i18n related stuff yet (if it even exists, haven't gotten that far or needed it). In general though I'm a strong supporter of internationalization support in software.

@icanc0
Copy link
Contributor

icanc0 commented Jun 21, 2024

i18n on the frontend should be easy, assuming that your family speaks a single language. we wont need API changes to support items with names in multiple languages etc.

@katosdev katosdev added good first issue Good for newcomers 👷‍♂️ help wanted Extra attention is needed labels Jun 22, 2024
@katosdev
Copy link
Contributor

Labelling as good first issue, open to community help! 👍🏻

@tankerkiller125
Copy link
Contributor

For anyone wanting to implement this feature. I don't mind any implementation. But I would really prefer an ICU Message format compatible/standard implementation given its flexibility and inclusiveness (given it was designed by unicee).

@tankerkiller125
Copy link
Contributor

Sill working on the full feature implementation, and getting all the existing strings switched over, however those wanting to contribute languages can start doing so at https://translate.sysadminsmedia.com/projects/homebox/frontend/

@tankerkiller125
Copy link
Contributor

I'm going to close this issue as it's i18n itself has been implemented. It's up to the community at this point to implement the languages they want to see via the weblate link shared previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⬆️ enhancement New feature or request good first issue Good for newcomers 👷‍♂️ help wanted Extra attention is needed
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants