Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Prometheus alerts #46

Closed
baurmatt opened this issue Jul 15, 2024 · 1 comment · Fixed by #48
Closed

Duplicate Prometheus alerts #46

baurmatt opened this issue Jul 15, 2024 · 1 comment · Fixed by #48

Comments

@baurmatt
Copy link
Member

Due to deployment simplicity, we run this exporter in multiple clusters within the same projects. This leads to duplicate metrics and thus wrong/duplicate alerts.

All alerts are currently created with the following schema:

sum((syseleven_xxx_used / syseleven_xxx_total) * 100) by(region, project) > 90

I suggest to change this to:

sum((max(syseleven_xxx_used)by(__name__, project, region) / max(syseleven_xxx_total)by(__name__, project, region)) * 100) by(project, region) > 90

This will give us only the largest metric of a project and region, no matter how often the metric got collected.

@cstruck
Copy link
Collaborator

cstruck commented Jul 16, 2024

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants