-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade react to v16. #329
Comments
@mitjade Lerna branch of this kit is perfectly working with React v16 for a month already. So I don't see any other problems, except that some of our dependencies are not ready yet. But if we can move away from these dependencies I'm all for it. I would like we give this a try as soon as possible |
@mitjade Build infra should be perfectly compatible with React v16. When I have tested it works even better with React v16, then with v15 |
so what's the plan? Improve |
@mairh get rid of |
I am for this as well. |
Since |
@mitjade Yep, I agree |
@Vlasenko I see you created a branch for |
@mitjade Yes, I'm working on this. Not all the deps are ready, but I'm going to find workarounds for all. |
I know this might be a bit early, since a lot of packages will take a while to all move to v16 and
react-native-web
is still not yet compatible, but should be soon (necolas/react-native-web#364).New version of RN uses now
react
v16.beta5 and we theoretically could make this kit already work with the latest RN and expo packages.I would rather remove
react-native-web
for now and have new RN (flatList, ...), but am not sure this is the only think that would break.@Vlasenko what are your thoughts. Should we wait a few moths or give this a try sooner?
The text was updated successfully, but these errors were encountered: