Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react to v16. #329

Closed
mitjade opened this issue Sep 6, 2017 · 9 comments
Closed

Upgrade react to v16. #329

mitjade opened this issue Sep 6, 2017 · 9 comments

Comments

@mitjade
Copy link
Collaborator

mitjade commented Sep 6, 2017

I know this might be a bit early, since a lot of packages will take a while to all move to v16 and react-native-web is still not yet compatible, but should be soon (necolas/react-native-web#364).

New version of RN uses now react v16.beta5 and we theoretically could make this kit already work with the latest RN and expo packages.

I would rather remove react-native-web for now and have new RN (flatList, ...), but am not sure this is the only think that would break.

@Vlasenko what are your thoughts. Should we wait a few moths or give this a try sooner?

@larixer
Copy link
Member

larixer commented Sep 6, 2017

@mitjade Lerna branch of this kit is perfectly working with React v16 for a month already. So I don't see any other problems, except that some of our dependencies are not ready yet. But if we can move away from these dependencies I'm all for it. I would like we give this a try as soon as possible

@larixer
Copy link
Member

larixer commented Sep 6, 2017

@mitjade Build infra should be perfectly compatible with React v16. When I have tested it works even better with React v16, then with v15

@mairh
Copy link
Member

mairh commented Sep 6, 2017

so what's the plan? Improve lerna branch to use v16 or implement v16 in the current master and get rid of react-native-web?

@larixer
Copy link
Member

larixer commented Sep 6, 2017

@mairh get rid of react-native-web and implement v16 in current master

@mitjade
Copy link
Collaborator Author

mitjade commented Sep 6, 2017

I am for this as well.

@mitjade
Copy link
Collaborator Author

mitjade commented Sep 8, 2017

Since react is already rolling out release candidates, we can probably wait until they release a stable version and for RN to use it as well. Hopefully this might be happening within a month, since RN has monthly release cycles.

@larixer
Copy link
Member

larixer commented Sep 8, 2017

@mitjade Yep, I agree

@mitjade
Copy link
Collaborator Author

mitjade commented Sep 25, 2017

@Vlasenko I see you created a branch for react16. Do you intend to upgrade this kit to react 16?

@larixer
Copy link
Member

larixer commented Sep 25, 2017

@mitjade Yes, I'm working on this. Not all the deps are ready, but I'm going to find workarounds for all.

@larixer larixer closed this as completed Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants