Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate failure on test_query_rules_fast_routing_algorithm-t #4829

Closed
renecannao opened this issue Feb 15, 2025 · 1 comment
Closed

Investigate failure on test_query_rules_fast_routing_algorithm-t #4829

renecannao opened this issue Feb 15, 2025 · 1 comment

Comments

@renecannao
Copy link
Contributor

On last CI run, test_query_rules_fast_routing_algorithm-t failed with these errors:

...
[2025-02-14 23:26:45] DEBUG    [proxysql-tester.py:698] msg: not ok 90 - 2025-02-14 23:26:45.518200 - Number of 'global' entries in SQLite3 'debug_log' should match issued queries - Exp: 20, Act: 20
...
[2025-02-14 23:26:46] DEBUG    [proxysql-tester.py:698] msg: not ok 111 - 2025-02-14 23:26:46.888280 - Number of 'global' entries in SQLite3 'debug_log' should match issued queries - Exp: 20, Act: 20
...

"Exp: 20, Act: 20" seems correct to me, not a "not ok".

Yet, in the code I see the following:

   ok(
        matching_rows == rng_end - rng_init,
        "Number of '%s' entries in SQLite3 'debug_log' should match issued queries - Exp: %d, Act: %ld",
        init_algo_scope.c_str(), rng_end - rng_init, matched_lines.size()
    );

and

    ok( 
        matching_rows == rng_end - rng_init,
        "Number of '%s' entries in SQLite3 'debug_log' should match issued queries - Exp: %d, Act: %ld",
        init_algo_scope.c_str(), rng_end - rng_init, matched_lines.size()
    );

The ok() clause and what displayed is different., thus there is at least a logical bug.

@JavierJF
Copy link
Collaborator

JavierJF commented Mar 5, 2025

This and the known failure for test_auth_methods-t were fixed by #4833. The test presented several logic issues that were fixed, and improved in other ways. Details in the link PR.

@JavierJF JavierJF closed this as completed Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants