Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 16.14.0 #1212

Closed
t2ca opened this issue Oct 14, 2020 · 6 comments
Closed

React 16.14.0 #1212

t2ca opened this issue Oct 14, 2020 · 6 comments

Comments

@t2ca
Copy link

t2ca commented Oct 14, 2020

I cannot build my site without getting errors ever since the release of React 16.14 which has added support for the new JSX transform. This is the same error that we had when upgrading to React17 #1160

edit: I was able to get it working again after downgrading gatsby-plugin-theme-ui back to v0.3.0

edit2: After going back to v0.3.0, I was able to upgrade to 0.4.0-rc.5 and it would keep working without any errors until I upgraded some other packages and the error would show up again. So each time i see the error, I will just install v0.3.0 followed by 0.4.0-rc.5.

edit3: I forgot to mention that i also had to change react and react-dom to 16.13.1

@t2ca t2ca changed the title React 16.4.0 React 16.14.0 Oct 14, 2020
@atanasster
Copy link
Collaborator

I believe this also waits on the emotion update - maybe close this issue as dupe?

@lachlanjc
Copy link
Member

@hasparus Duplicate of Emotion 11/React 17 Runtime support, we can close

@t2ca t2ca closed this as completed Nov 22, 2020
@chenrui333
Copy link

@lachlanjc, 👋 can you attach the link for Emotion 11/React 17 Runtime support (I am also looking for the React 17 compatibility support)? Thanks!

@lachlanjc
Copy link
Member

That would be #1237!

@chenrui333
Copy link

Ah, so this is already done. That is awesome! 🎉

@hasparus
Copy link
Member

hasparus commented Jan 22, 2021

@chenrui333 it's not yet in stable release.

BTW React 17 was always working -- it was just the automatic runtime support and people were surprised by the change of defaults in CRA.

You can still use the classic JSX runtime (if you can configure your Babel config) with React 17, so even the oldest versions of Theme UI should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants