Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit and integration test coverage to query request by id service #190

Closed
mxfactorial opened this issue May 19, 2020 · 5 comments
Closed

Comments

@mxfactorial
Copy link
Contributor

mxfactorial commented May 19, 2020

  1. add unit test coverage to services/req-query-trans-id-faas
  2. go test -cover

expected
majority coverage


  1. add integration test coverage to services/req-query-trans-id-faas
  2. insert transaction record with all values assigned into postgres db
  3. invoke lambda with transaction id

expected
lambda returns request record with assigned values

@cicika
Copy link

cicika commented May 21, 2020

  1. Refactor to make code testable
  2. Create test data for unit tests with SQLite
  3. Create integration test with test PG instance (can reuse from previous point)
  4. Update CI files to run new tests

I will overshoot with the estimate, just in case :)
Estimate: 3h
Delivery: Fri, May 22nd

@mxfactorial
Copy link
Contributor Author

approved, from develop please

@mxfactorial
Copy link
Contributor Author

Delivery: Fri, May 22nd

intended?

@cicika
Copy link

cicika commented May 23, 2020

It was. Got slightly stuck running integration test locally, will update soon.

@mxfactorial
Copy link
Contributor Author

filling holes in process script. new version:

1. requirements added as github issues by maintainer
2. maintainer solicits estimation from developer
3. developer issues delivery date and itemized hourly estimation budgeting for i) feature addition or fix, ii) unit tests, iii) integration tests, iv) code review and v) code review changes
4. maintainer approves estimation from developer
5. developer branches and creates wip pull request
6. developer proposes new delivery date and itemized hourly estimation of obstacles posing risk to initially negotiated estimation
7. maintainer eliminates obstacles posing risk to initially negotiated estimation
8. maintainer accepts or rejects new estimation
9. developer finishes pull request
10. unless negotiated, developer maintains or increases code coverage
11. developer requests code review from maintainer
12. developer adds changes required during code review
13. all tests pass before or on accepted delivery date
14. maintainer merges pull request
15. maintainer pays developer

please comment approval or rejection in billing tool

if rejecting, please close wip pull request
else, begin from #6 by posting comment here

process script aims to protect maintainer from management costs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants