-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor pixel differences with wrench #56
Comments
Ok, I wouldn't worry about this in particular. We can just add a fuzzy value to those tests if max difference is just 1. Must be some differently configured (by the driver) samplers or the rasterizer. |
This list contains tests with minor pixel differences (which have the same results as (windowed) opengl) The full list for opengl test fails is here and for vulkan is here.
|
OpenGL fails Our vulkan backend passes and fails the
It looks to me that maybe a sampler/filter/blend is wrong in some cases. |
The remaining test are only differ in some pixel, maybe these are rounding/precision errors(?) |
We checked and these tests have the same pixel difference as opengl on windows-vulkan:
Also the yuv test is fixed. Which leaves us with 3 failing tests on linux-vulkan. Also there are some (~7) differing tests that only present on windows-vulkan, not in linux-vulkan. |
The previously mentioned differing tests will be resolved when #164 lands. There are two tests that differ from linux-vulkan
This means we have 2 fails in both windows and linux vulkan:
Note: The #156 still exists but its working fine on windows, so must be a linux/driver thing(?) |
The DX12 results: And we have 19 tests that uses blitting, and it is unsupported in dx12 at the moment:
Everything else is the same as the vulkan-windows results. |
The difference is only with the OSMesa GL. Since we comparing our results with the windowed GL and those are (almost) the same, we can close this issue. |
We tried the following test:
https://github.com/szeged/webrender/blob/master/wrench/reftests/border/border-clamp-corner-radius.yaml
Which has a reference image: (we use it flipped for now)
https://github.com/szeged/webrender/blob/master/wrench/reftests/border/border-clamp-corner-radius-ref.png
The result of the test: https://gist.github.com/zakorgy/cb95b2b9e7158ce557f67ec71e9fc8fa
image comparison, max difference: 1, number of differing pixels: 29
Usually we use the following site to compare images quickly: https://huddle.github.io/Resemble.js/
A screenshot about the compare (the purple dots represent the differences, 29 as the result above indicate):
cc @kvark
The text was updated successfully, but these errors were encountered: