Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3-segment wallpapers doesn't seem to work #442

Closed
t1m0thyj opened this issue May 14, 2022 Discussed in #429 · 4 comments
Closed

3-segment wallpapers doesn't seem to work #442

t1m0thyj opened this issue May 14, 2022 Discussed in #429 · 4 comments
Labels
enhancement New feature or request

Comments

@t1m0thyj
Copy link
Owner

Discussed in #429

Originally posted by ilverogattuso April 11, 2022
I am quite fond of this app, which is why I decided to give it a try and make my own custom themes, that's when I spotted what I think is an error, which is triggered when in the .json you only include 3 out of the 4 Image Lists (in my case I included all and omitted sunrise), afterwards, when selecting the theme from the app, an error will pop-up, so when checking the log it mostly says:

System.IndexOutOfRangeException: Index was outside the bounds of the array.

The current workaround is to include all 4 phases and repeat one image number in the .json, I tried this with sunset and sunrise as well as sunrise and day, and that way it works just fine!
Just wanted to know if this happens to anyone else.
Anyways love your work sir and thanks in advance!

@wkdk
Copy link

wkdk commented May 14, 2022

I just ignore the pop-up, then click "Apply". Theme is being applied and working without any issue.

For example this: LoFiGirl theme

@watchmakerful
Copy link

Confirmed also with the "Adwaita" theme containing day, night and sunset, but no sunrise. The easiest way to avoid this error is to add the missing phase (e. g. sunrise) with the same image number as the opposite phase.

@t1m0thyj t1m0thyj self-assigned this Sep 7, 2022
@t1m0thyj
Copy link
Owner Author

t1m0thyj commented Jan 3, 2023

The easiest way to avoid this error is to add the missing phase (e. g. sunrise) with the same image number as the opposite phase.

Supporting 3-segment wallpapers is a valid enhancement request but low priority IMO since this workaround exists. If you want to raise more attention to it, please comment or upvote on this issue.

@t1m0thyj t1m0thyj removed their assignment Jan 3, 2023
@t1m0thyj t1m0thyj added the enhancement New feature or request label Jan 3, 2023
@t1m0thyj
Copy link
Owner Author

Added support for 3-segment themes like Adwaita in v5.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants