Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minified 2.1.0 on NPM is not the correct version #847

Closed
pkeuter opened this issue Jul 2, 2018 · 1 comment
Closed

Minified 2.1.0 on NPM is not the correct version #847

pkeuter opened this issue Jul 2, 2018 · 1 comment

Comments

@pkeuter
Copy link

pkeuter commented Jul 2, 2018 •
edited
Loading

For example this PR: #771 is not implemented in https://registry.npmjs.org/sweetalert/-/sweetalert-2.1.0.tgz, col 35630 says this: setTimeout(function(){t.focus(),a.setActionValue("")},0)} while with the PR this should have been changed to setTimeout(function(){t.focus();var e=t.value;a.setActionValue(e)},0)}

Maybe something went wrong while building the 2.1.0 version? @t4t5 Is there a way we can get the correct version on NPM?

Thanks!
@pkeuter
Copy link
Author

pkeuter commented Jul 2, 2018 •
edited
Loading

Okay apparently I didn't see this has been reverted in: d1fe279. Why has this been reverted?

@pkeuter pkeuter closed this as completed Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pkeuter