New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force overriding obsolete hooks to be errors #12

Open

JavidPack opened this issue Jul 31, 2022 · 1 comment

Contributor

JavidPack commented Jul 31, 2022

The override is treated as just a warning, despite [Obsolete(error: true)] on the hooks

Member

Chicken-Bones commented Aug 1, 2022

Make sure it only errors if:

The base method/property has error: true
The overriding method is not marked as [Obsolete]
- This is important to preserve the 'obsolete non-error can call/work with obsolete-error code' behaviour, which is a useful temporary workaround to halts in your dev-team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment