Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create info-button #54

Open
simenandre opened this issue Sep 21, 2020 · 12 comments
Open

Create info-button #54

simenandre opened this issue Sep 21, 2020 · 12 comments
Assignees

Comments

@simenandre
Copy link
Member

Skjermbilde 2020-09-21 kl  20 37 52

This needs more description. @AnneMatilde can you pitch in?

@AnneMatilde
Copy link
Contributor

This is now updated in the design-file @cobraz

@TanyaDolgopolova
Copy link
Contributor

@AnneMatilde
Copy link
Contributor

Hi @TanyaDolgopolova! Icon for info-button is now added to the icon-folder: https://drive.google.com/file/d/1LsOMQb412-3b5AJjdat7kcv_ZkUBB34T/view?usp=sharing

@TanyaDolgopolova
Copy link
Contributor

@AnneMatilde I have a question about design on modal window. The design of window should be with dark background or its not completed?
Screenshot 2020-10-15 at 10 02 45

@AnneMatilde
Copy link
Contributor

Hey @TanyaDolgopolova! Yes, I would like the pop-up to be dark blue, and the text inside it white.

@TanyaDolgopolova
Copy link
Contributor

Hey @TanyaDolgopolova! Yes, I would like the pop-up to be dark blue, and the text inside it white.

Okay, thanks

@TanyaDolgopolova
Copy link
Contributor

@cobraz I have some struggles with generating a new svg icon for component. As I understand, we need generate icon via yarn run generate command with adding icon to the icons folder in the root of the project. Also, I use svgo library for optimisation the added icon. But new file are not generates, maybe I something miss?

@simenandre
Copy link
Member Author

It's quite some time since I did generate icons, let me check :)

@simenandre
Copy link
Member Author

If you did it according to documentation, you should be in the clear?

https://github.com/tabetalt/kit/blob/master/docs/adding-icons.md

@TanyaDolgopolova
Copy link
Contributor

Yes, I did all steps by documentation

@simenandre
Copy link
Member Author

Hmm, no changes. Can you send me the icon and I'll try and troubleshoot ?

@TanyaDolgopolova
Copy link
Contributor

Hi @TanyaDolgopolova! Icon for info-button is now added to the icon-folder: https://drive.google.com/file/d/1LsOMQb412-3b5AJjdat7kcv_ZkUBB34T/view?usp=sharing

@cobraz yeah, by this link you can download icon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants