Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing/incorrect colours #632

Open
GarySiu opened this issue Jul 29, 2019 · 3 comments
Open

Missing/incorrect colours #632

GarySiu opened this issue Jul 29, 2019 · 3 comments

Comments

@GarySiu
Copy link

GarySiu commented Jul 29, 2019

Cross-posting an issue from the docs repo:
tachyons-css/tachyons-css.github.io#193

It seems like somewhere along the line the yellows in tachyons were mixed up. This is reflected both in the CSS and in the docs: http://tachyons.io/docs/themes/skins/

#FFFF00 should be yellow but has no name/is missing from Tachyons!
#FFD700 should be gold (in line with the CSS keyword) but has been assigned yellow
#FFB700 is some mystery orange variant but assigned gold
#FF6300 is some mystery orange red variant but assigned orange

On the docs page this visually breaks the layout as yellow is unnamed.

@orionrush
Copy link

from _variables.scss in tachyons-sass

$orange: #ff6300 !default; "mystery orange red variant"
$gold: #ffb700 !default; "some mystery orange variant"
$yellow: #ffd700 !default; "should be gold (in line with the CSS keyword)"
$light-yellow: #fbf1a9 !default; –– missing?

#FFFF00 does not appear in _variables.scss

@GarySiu
Copy link
Author

GarySiu commented Sep 30, 2019

Yes. But it's used multiple times in the docs and breaking the layout there which is why I'm reporting it:

Screenshot of the missing text
Second screenshot showing gap in layout

@andrewhainen
Copy link

The #FFFF00 being unlabeled has been confusing me as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@orionrush @GarySiu @andrewhainen and others