Fix http_auth_types for :any and :anysafe #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (!strncmp("ntlm",node,4)) ? CURLAUTH_NTLM : \ | ||
| (!strncmp("any",node,3)) ? CURLAUTH_ANY : \ | ||
| (!strncmp("anysafe",node,7)) ? CURLAUTH_ANYSAFE : 0 | ||
| (!strcmp("basic",node)) ? CURLAUTH_BASIC : \ |
There was a problem hiding this comment.
the use of strcmp is unbounded in this case it assumes - the input is null terminated but what if it's not... any reason to replace strncmp with strcmp?
There was a problem hiding this comment.
strncmp("any", "anysafe", 3) returns 0, so CURLAUTH_ANY was used for :anysafe.
I have updated the pull request with a less intrusive bugfix: check for "anysafe" first, then for "any".
Curb did not allow negative values for http_auth_types, but the values for CURLAUTH_ANY and CURLAUTH_ANYSAFE are negative. This also fixes the bug that curb used :any instead of :anysafe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curb did not allow negative values for http_auth_types, but the values for
CURLAUTH_ANY and CURLAUTH_ANYSAFE are negative.
This also fixes the bug that curb used :any instead of :anysafe.