Use LONG2NUM and NUM2LONG to support all values of the 'long' type #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some values of the 'long' type cannot be represented as a Fixnum, e.g. the curl constant CURLAUTH_ANY is a Bignum. In order to support such values, LONG2NUM and NUM2LONG must be used. INT2FIX, FIX2INT, FIX2LONG and LONG2FIX must not be used (except in some special cases), because the value may get truncated. The performance impact of this change is very small and negligible. Setting 'http_auth_types = :any' now really works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some values of the 'long' type cannot be represented as a Fixnum, e.g. the curl constant
CURLAUTH_ANYis a Bignum.In order to support such values,
LONG2NUMandNUM2LONGmust be used.INT2FIX,FIX2INT,FIX2LONGandLONG2FIXmust not be used (except in some special cases), because the value may get truncated.The performance impact of this change is very small and negligible.
Setting
http_auth_types = :anynow really works.