Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting to zigzag exchange gives unexpected error #2818

Open
Naxsun opened this issue Dec 28, 2022 · 2 comments · Fixed by #3546
Open

Connecting to zigzag exchange gives unexpected error #2818

Naxsun opened this issue Dec 28, 2022 · 2 comments · Fixed by #3546
Assignees
Labels
Priority: Low Low Monetary / Growth impact, not time-sensitive. Status: Available Available to work on Type: Bug Something isn't working

Comments

@Naxsun
Copy link
Contributor

Naxsun commented Dec 28, 2022

Discord Discussion Link

n/a

What browsers are you seeing the problem on?

Chrome

What were you trying to do?

Connect to ZigZag exchange

What did not work?

Extension pops up with an 'unexpected error' message

ZigZag.error.mov

Version

v0.18.6

Relevant log output

No response

@Naxsun Naxsun added Type: Bug Something isn't working Status: Pending Needs further attention and categorization labels Dec 28, 2022
@0xDaedalus 0xDaedalus added Status: Available Available to work on Priority: Low Low Monetary / Growth impact, not time-sensitive. and removed Status: Pending Needs further attention and categorization labels Feb 16, 2023
@Shadowfiend
Copy link
Contributor

This is because we're receiving an unexpected first parameter in the eth_requestAccounts call, which looks like { "eth_accounts": {} }. In fact, we should be ignoring any parameters to that call, meaning the following line should replace rather than push:

event.data.request.params.push(title, faviconUrl)

@kkosiorowska
Copy link
Contributor

The issue has not been fully resolved by #3546. The error has disappeared, but we still cannot connect.

@kkosiorowska kkosiorowska reopened this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Low Monetary / Growth impact, not time-sensitive. Status: Available Available to work on Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants