Make sure KernelTemplateMapper extractors's size is the same as the number of args #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umber of args Fixes taichi-dev#531
|
Cool, thanks! |
xumingkuan
pushed a commit
to xumingkuan/taichi
that referenced
this pull request
Feb 26, 2020
…umber of args (taichi-dev#534) * Make sure KernelTemplateMapper extractors's size is the same as the number of args Fixes taichi-dev#531 * fix test
yuanming-hu
added a commit
that referenced
this pull request
Feb 26, 2020
* tmp * Avoid duplicate evaluations in chaining comparison * minor: new line * removed taichi/lang.h and taichi/llvm_jit.h * tmp * Make sure KernelTemplateMapper extractors's size is the same as the number of args (#534) * Make sure KernelTemplateMapper extractors's size is the same as the number of args Fixes #531 * fix test * Update README.md * Avoid duplicate evaluations in chaining comparison * minor: new line * improve tests * Do not apply the generic visitor if the function called is ti.static * Disallow Expr.__getitem__ in Taichi-scope Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com> Co-authored-by: Ye Kuang <k-ye@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #531