-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): correct reuse of viewport for hint position #10183
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
bd25f4d
to
d0f113b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10183 +/- ##
=======================================
Coverage 65.83% 65.84%
=======================================
Files 1233 1233
Lines 16091 16083 -8
Branches 2363 2341 -22
=======================================
- Hits 10594 10590 -4
- Misses 5213 5241 +28
+ Partials 284 252 -32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Visit the preview URL for this PR (updated for commit 17dd781): https://taiga-previews-demo--pr10183-splincode-fix-issues-1012-8cyojrg1.web.app (expires Sat, 18 Jan 2025 10:15:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37 |
BundleMonFiles updated (2)
Unchanged files (3)
Total files change +34B +0.01% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
fa12a0c
to
648ea18
Compare
648ea18
to
fee2e87
Compare
f07ad79
to
17dd781
Compare
Playwright test results
Details
Failed testschromium › tests/core/dropdown/dropdown.pw.spec.ts › Dropdown › Hosted dropdown initial width Skipped testswebkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › input card grouped with validation |
Fixes #10124
Screen.Recording.2025-01-17.at.12.42.09.PM.mov