Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): display view/hide password button with readOnly property #8584

Merged

Conversation

olegnowikow
Copy link
Contributor

Closes #6973

Copy link

lumberjack-bot bot commented Aug 17, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.05%. Comparing base (43c0ebb) to head (3726430).
Report is 1357 commits behind head on main.

Files Patch % Lines
...ponents/input-password/input-password.component.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8584      +/-   ##
==========================================
- Coverage   70.19%   67.05%   -3.14%     
==========================================
  Files        1460     1171     -289     
  Lines       15934    15047     -887     
  Branches     2292     2068     -224     
==========================================
- Hits        11185    10090    -1095     
- Misses       4369     4807     +438     
+ Partials      380      150     -230     
Flag Coverage Δ
summary 67.05% <50.00%> (-3.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Aug 17, 2024

BundleMon

Files updated (4)
Status Path Size Limits
demo/browser/main.(hash).js
280.67KB (+59B +0.02%) +10%
demo/browser/styles.(hash).css
11.56KB (+16B +0.14%) +10%
demo/browser/runtime.(hash).js
41.52KB (-52B -0.12%) +10%
demo/browser/vendor.(hash).js
216.25KB (-53B -0.02%) +10%
Unchanged files (1)
Status Path Size Limits
demo/browser/polyfills.(hash).js
11.21KB +10%

Total files change -30B -0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
6.79MB (-8.41KB -0.12%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode added the v4 4.0 candidate label Aug 19, 2024
@waterplea waterplea merged commit 15857bc into taiga-family:main Aug 20, 2024
27 of 28 checks passed
@olegnowikow olegnowikow deleted the fix/display-icon-password-button branch August 20, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 4.0 candidate
Development

Successfully merging this pull request may close these issues.

🐞 - tui-input-password does not display the view/hide password button
3 participants