-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kit): ItemsWithMore
add side
option
#9363
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Visit the preview URL for this PR (updated for commit d47ec9d): https://taiga-previews--pr9363-items-with-more-recj986v.web.app (expires Tue, 08 Oct 2024 11:59:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a |
BundleMonFiles updated (2)
Unchanged files (3)
Total files change +229B +0.04% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Playwright test fails
[chromium] › tests/kit/action-bar/action-bar.mobile.spec.ts:20:9 › ActionBar › works
1) [chromium] › tests/kit/action-bar/action-bar.mobile.spec.ts:20:9 › ActionBar › works ──────────
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: locator.click: Error: strict mode violation: locator('tui-action-bar').locator('button:has-text("More")') resolved to 2 elements:
1) <button tuiicons="" tuibutton="" type="button" data-size="m" tuiappearance="" tuidropdownopen="" data-appearance="glass" tuidropdownalign="right" class="ng-star-inserted" iconstart="@tui.ellipsis"> More </button> aka locator('tui-items-with-more').getByText('More')
2) <button tuiicons="" type="button" data-size="m" tuiappearance="" tuiiconbutton="" data-appearance="glass" class="ng-star-inserted" iconstart="@tui.ellipsis"> More </button> aka locator('tui-action-bar').getByRole('button', { name: 'More' })
eaf3f2d
to
4bdc96e
Compare
Fixes #8039