Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): ItemsWithMore add side option #9363

Merged
merged 7 commits into from
Oct 7, 2024
Merged

feat(kit): ItemsWithMore add side option #9363

merged 7 commits into from
Oct 7, 2024

Conversation

waterplea
Copy link
Collaborator

Fixes #8039

Copy link

lumberjack-bot bot commented Oct 7, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Visit the preview URL for this PR (updated for commit d47ec9d):

https://taiga-previews--pr9363-items-with-more-recj986v.web.app

(expires Tue, 08 Oct 2024 11:59:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Oct 7, 2024

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
294.03KB (+201B +0.07%) +10%
demo/browser/runtime.(hash).js
43KB (+28B +0.06%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
247.33KB +10%
demo/browser/styles.(hash).css
16.27KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +229B +0.04%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.11MB (+6.54KB +0.09%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Member

@nsbarsukov nsbarsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playwright test fails

[chromium] › tests/kit/action-bar/action-bar.mobile.spec.ts:20:9 › ActionBar › works

  1) [chromium] › tests/kit/action-bar/action-bar.mobile.spec.ts:20:9 › ActionBar › works ──────────

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    Error: locator.click: Error: strict mode violation: locator('tui-action-bar').locator('button:has-text("More")') resolved to 2 elements:
        1) <button tuiicons="" tuibutton="" type="button" data-size="m" tuiappearance="" tuidropdownopen="" data-appearance="glass" tuidropdownalign="right" class="ng-star-inserted" iconstart="@tui.ellipsis"> More </button> aka locator('tui-items-with-more').getByText('More')
        2) <button tuiicons="" type="button" data-size="m" tuiappearance="" tuiiconbutton="" data-appearance="glass" class="ng-star-inserted" iconstart="@tui.ellipsis"> More </button> aka locator('tui-action-bar').getByRole('button', { name: 'More' })

@waterplea waterplea merged commit 47d7178 into main Oct 7, 2024
24 of 25 checks passed
@waterplea waterplea deleted the items-with-more branch October 7, 2024 12:12
This was referenced Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Tui Items With More - sometimes content is not correctly calculated to fit inside available space
5 participants