Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): Switch should have dark knob for the dark theme in web platform #9658

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented Nov 1, 2024

Previous behavior

Снимок экрана 2024-11-01 в 12 24 45

New behavior

Снимок экрана 2024-11-01 в 12 27 37

@nsbarsukov nsbarsukov self-assigned this Nov 1, 2024
@nsbarsukov nsbarsukov requested a review from a team as a code owner November 1, 2024 09:25
@nsbarsukov nsbarsukov requested review from MarsiBarsi, waterplea, vladimirpotekhin and mdlufy and removed request for a team November 1, 2024 09:25
Copy link

lumberjack-bot bot commented Nov 1, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Visit the preview URL for this PR (updated for commit 48262f8):

https://taiga-previews--pr9658-switch-know-dark-the-75w4fj57.web.app

(expires Sat, 02 Nov 2024 09:29:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Nov 1, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
298.46KB +10%
demo/browser/vendor.(hash).js
259.74KB +10%
demo/browser/runtime.(hash).js
43.39KB +10%
demo/browser/styles.(hash).css
19.61KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +3B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.23MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@nsbarsukov nsbarsukov merged commit 1c9664a into main Nov 1, 2024
27 of 28 checks passed
@nsbarsukov nsbarsukov deleted the switch-know-dark-theme-fix branch November 1, 2024 10:54
shiv9604 pushed a commit to shiv9604/taiga-ui that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants