Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 - TuiTime.shift doesn't shift higher order units #9817

Closed
DmitryBrovchenko opened this issue Nov 22, 2024 · 1 comment · Fixed by #10065
Closed

🐞 - TuiTime.shift doesn't shift higher order units #9817

DmitryBrovchenko opened this issue Nov 22, 2024 · 1 comment · Fixed by #10065
Assignees
@reverie3
Labels
community contribution This issue was closed by a PR from the community

Comments

@DmitryBrovchenko
Copy link

Reproduction url

https://stackblitz.com/edit/angular-omavrt?file=src%2Fapp%2Fapp.component.ts,src%2Fapp%2Fapp.template.html&hideExplorer=1

Description

TuiTime.shift doesn't change minutes and hours, when changing seconds should result in their change, or hours when changing minutes.

Image

It complicates time related operations. The expected behavior is similar to TuiDay.append, which modifies other units.

Taiga UI version

3.98.0

Browser Used

Chrome

OS Used

Windows
@reverie3
Copy link
Contributor

I'd like to help with this issue.

@reverie3 reverie3 mentioned this issue Dec 26, 2024
Merged
@waterplea waterplea added the community contribution This issue was closed by a PR from the community label Dec 26, 2024
@reverie3 reverie3 mentioned this issue Dec 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reverie3 reverie3

Labels
community contribution This issue was closed by a PR from the community
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cdk): TuiTime.shift doesn't shift higher order units reverie3/taiga-ui
3 participants
@waterplea @reverie3 @DmitryBrovchenko