Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): DropdownOpen has CD problems after switching of tuiDropdownEnabled (false=>true) #9888

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

nsbarsukov
Copy link
Member

Reproduction

<tui-input [formControl]="control">
  Enter 3 characters
  
  @if (control.value.length > 2) {
    <tui-data-list *tuiDataList> Blah blah </tui-data-list>
  }
</tui-input>

Enter 123

Expected behavior: dropdown appears
Actual behavior: no dropdown

Explore more:
https://stackblitz.com/edit/input-with-datalist-v4-bug?file=src%2Fapp%2Fapp.template.html

…downEnabled` (`false`=>`true`)
@nsbarsukov nsbarsukov self-assigned this Dec 3, 2024
Copy link

lumberjack-bot bot commented Dec 3, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Visit the preview URL for this PR (updated for commit 4d2e95e):

https://taiga-previews-demo--pr9888-input-data-list-fix-demo-6ydpbzxo.web.app

(expires Wed, 04 Dec 2024 08:33:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

bundlemon bot commented Dec 3, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
304.09KB +10%
demo/browser/vendor.(hash).js
260.11KB +10%
demo/browser/runtime.(hash).js
43.78KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +2B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.32MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Playwright test results

passed  975 passed

Details

report  Open report ↗︎
stats  975 tests across 69 suites
duration  8 minutes, 51 seconds
commit  4d2e95e

@nsbarsukov nsbarsukov marked this pull request as ready for review December 3, 2024 08:33
@nsbarsukov nsbarsukov requested a review from a team as a code owner December 3, 2024 08:33
@nsbarsukov nsbarsukov requested review from MarsiBarsi, waterplea, vladimirpotekhin and mdlufy and removed request for a team December 3, 2024 08:33
@splincode splincode merged commit 4249cd9 into main Dec 3, 2024
27 checks passed
@splincode splincode deleted the input-data-list-fix branch December 3, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants