fix(raiko): make kzg work on SP1 #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #201 yesterday I wasn't testing in the PR branch, but in my own branch with some additional changes. Turns out some of these additional changes are also required to make c-kzg work correctly on SP1:
no-threadsfeature in c-kzg-march=rv32im -mstrict-align -falign-functions=2, not just-mstrict-alignFor consistency I also made risc zero compile with the same flags because normally risc zero has the same limitations (though somehow in practice not, so maybe some extra flags are enabled somehow elsewhere).
Also made it so now block 10136 is tested locally which was the block that failed before the fix (the old one didn't require the fix somehow). It's not tested on CI because the machine doesn't have enough memory. :(