-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(host,provers,tasks): handle local job cancellation #345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make some tests for the request & cancel process? I think we need to cover more as the v2 will be online soon. to make our future life easier, we need to do it. however, I don't know if there is a good way to test server API, maybe not easy to write simple unit test for it??
anyway, I came up with few cases, and I believe there are more than these, let's try to cover them as more as possible.
- request->mock crash->request(should return the right error status)
- request->cancel->request(returns cancel by user or restarts the task??)
- request repeatly or cancel repeatly
@smtmfft I agree, we need to have testing for this. This, however is not a simple unit test, rather a end-to-end test where we go through a whole request flow with all the components spun up. I've already been playing around with this, but I need to add it to CI and polish it further to be good. BTW
This restarts the task, but we should have a test enforcing this behavior |
great! I think you can take current ontake upgrade to improve it. |
No description provided.