fix: incorrect state transition handling

[johntaiko]

Background

We had an issue of block 380550 on our Mainnet when processing stress test.

2024-10-13T08:58:58.429218Z ERROR raiko_host::proof: There was an error with the core: There was an error with a guest prover: ProverError::GuestError `Condition failed: `self.input.block.state_ro
ot == state_root``

It told me, the state root of Raiko is different from Geth. My first impression is that there are differences in the modifications to Accounts during the execution of EVM. But...

Root cause

I found that there was an unexpected account-deleted behavior in Raiko.

And there are two transactions related to it in block 380550,

no	role	value
969	to	0 ETH
977	to	0.0001 ETH

Because the first one received zero ETH, so it's nonce and balance weren't changed. But, Revm marked it as Destroyed.

(LoadedEmptyEIP161 → Destroyed)

And the second one let the status convert from Destroyed to DestroyedChanged

Revm has a function to tell people whether the Account is destroyed.

Raiko considered it an account-deleted action. Actually, it can't. The DestroyedChanged maybe happened in our issue.

Conclusion

The first transaction did not change the account information, no data needs to be stored, but it was marked as Destroyed by EIP161. The followed second transaction's status in the same block changed from Destroyed to DestroyedChanged. We simply assume that DestroyedChanged is what needs to be deleted.

Debug journey

1. I thought the issue was due to EVM execution differences, so I compared the EVM execution traces of Geth and Reth to troubleshoot, but ultimately, they were identical.
2. I troubleshoot the issue by comparing state changes after each transaction execution in EVM. They were also the same.
3. Finally, I tracked the state changes in the Raiko's MemDB, and discovered the differences.

Future plan

Replace it with Raiko-in-Reth project. Raiko added an extra state transformation. It may be more prone to bugs.

(Account status from Revm)

(Account status from Raiko)

[Brechtpd]

MPT will be our end.