Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

feat(proposer): check tko balance and fee before proposing #205

Merged
merged 10 commits into from
May 3, 2023

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented May 2, 2023

closes #203
sorry roger, i thought this was assigned me to but had the wrong issue open :D.

tests are not failing due to my code changes, perhaps genesis issue?

@cyberhorsey cyberhorsey changed the title feat(proposer): check tko balance nad fee before proposing feat(proposer): check tko balance and fee before proposing May 2, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #205 (a53dd58) into main (98e7107) will decrease coverage by 0.56%.
The diff coverage is 36.84%.

❗ Current head a53dd58 differs from pull request most recent head d198fe3. Consider uploading reports for the commit d198fe3 to get more accurate results

@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   53.90%   53.34%   -0.56%     
==========================================
  Files          36       36              
  Lines        3163     3181      +18     
==========================================
- Hits         1705     1697       -8     
- Misses       1238     1260      +22     
- Partials      220      224       +4     
Impacted Files Coverage Δ
proposer/proposer.go 63.18% <36.84%> (-2.94%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidtaikocha
Copy link
Member

tests are not failing due to my code changes, perhaps genesis issue?

Its a bindings issue, updated.

@cyberhorsey cyberhorsey requested a review from davidtaikocha May 3, 2023 01:39
@davidtaikocha davidtaikocha enabled auto-merge (squash) May 3, 2023 03:20
@davidtaikocha davidtaikocha merged commit cc0da63 into main May 3, 2023
@davidtaikocha davidtaikocha deleted the check_token_balance branch May 3, 2023 03:22
vhjiang pushed a commit to taikoverse/taiko-degen-client that referenced this pull request Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(proposer): check current proposer's Taiko token balance && block fee before each proposing operation
2 participants