This repository has been archived by the owner on May 11, 2024. It is now read-only.
feat(proposer): add a --minimalBlockGasLimit flag to mitigate the potential gas estimation issue
#225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otential gas estimation issue
Codecov Report
@@ Coverage Diff @@
## main #225 +/- ##
==========================================
+ Coverage 52.74% 52.97% +0.22%
==========================================
Files 36 36
Lines 3405 3417 +12
==========================================
+ Hits 1796 1810 +14
+ Misses 1374 1370 -4
- Partials 235 237 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I like this better than modifying geth, which IMO should be kept to the bare minimum of modifications. |
cyberhorsey
approved these changes
May 15, 2023
vhjiang
pushed a commit
to taikoverse/taiko-degen-client
that referenced
this pull request
Jul 1, 2023
…otential gas estimation issue (taikoxyz#225) Co-authored-by: jeff <113397187+cyberhorsey@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to change the geth codebase as less as possible, we can do this. or @cyberhorsey u think changing the geth codebase will be a better option?