This repository has been archived by the owner on May 11, 2024. It is now read-only.
feat(pkg): do not return error when genesis block not found #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerLamTd
approved these changes
May 26, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overall, this Pull Request looks good. The code changes are minimal and seem to address the commit message well.
- The log statement should be improved to include more useful information for debugging purposes.
- Consider adding a comment above the log statement to explain why it is being used in this context.
- It would also be a good idea to add a test case that verifies the behavior of this code when a genesis block is not found.
vhjiang
pushed a commit
to taikoverse/taiko-degen-client
that referenced
this pull request
Jul 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.