Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BridgeUI): <SelectChain /> Arrow Right button not visible in light mode if no wallet is connected #13030

Closed
kyrers opened this issue Jan 24, 2023 · 0 comments · Fixed by #13089

Comments

@kyrers
Copy link

kyrers commented Jan 24, 2023

Describe the bug

The ArrowRight /> button in the <SelectChain /> component is not visible in light mode if no wallet is connected.
This happens because the button is disabled if !$signer.

I'd be more than glad to solve this issue for you, but I do want to hear your preference before making a PR.
For what it's worth, I do agree that the button should be disabled in this instance. As I see it, the easiest option that does not modify anything else, as far as I can tell, is creating a specific style for [data-theme="light"] .btn:disabled svg and modifying the color property. In the screenshots, I used dark-color-6 as it seemed the closest to the "Approve" color, but that it's still visible.

I will of course solve it any way you wish.

Steps to reproduce

  1. Go to the Brigde UI;
  2. Disconnect your wallet;
  3. Switch to light mode.

Additional context

Problem
Problem
Proposed Fix - Light Mode
image
Proposed Fix - Dark Mode
image

@kyrers kyrers changed the title fix: <SelectChain /> Arrow Right button not visible in light mode if no wallet is connected fix(BridgeUI): <SelectChain /> Arrow Right button not visible in light mode if no wallet is connected Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant