Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): add proto_broker / oracle_prover addresses into AddressManager in deploy_L1 script #13079

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

davidtaikocha
Copy link
Member

@davidtaikocha davidtaikocha commented Jan 31, 2023

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #13079 (bed0010) into main (d69c369) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #13079      +/-   ##
==========================================
+ Coverage   64.34%   64.41%   +0.06%     
==========================================
  Files         112      112              
  Lines        3122     3122              
  Branches      396      396              
==========================================
+ Hits         2009     2011       +2     
+ Misses       1037     1035       -2     
  Partials       76       76              
Flag Coverage Δ *Carryforward flag
bridge-ui 92.61% <ø> (ø) Carriedforward from 53019c2
protocol 55.94% <ø> (+0.12%) ⬆️
relayer 68.92% <ø> (ø) Carriedforward from 53019c2
ui 100.00% <ø> (ø) Carriedforward from 53019c2

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ges/protocol/contracts/libs/LibAnchorSignature.sol 100.00% <0.00%> (+10.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidtaikocha davidtaikocha marked this pull request as ready for review January 31, 2023 08:24
alexshliu
alexshliu previously approved these changes Jan 31, 2023
@davidtaikocha davidtaikocha marked this pull request as draft January 31, 2023 08:28
@davidtaikocha davidtaikocha marked this pull request as ready for review January 31, 2023 08:34
@davidtaikocha davidtaikocha changed the title feat(protocol): add proto_broker address into AddressManager in deploy_L1 script feat(protocol): add proto_broker / oracleProver addresses into AddressManager in deploy_L1 script Jan 31, 2023
@davidtaikocha davidtaikocha changed the title feat(protocol): add proto_broker / oracleProver addresses into AddressManager in deploy_L1 script feat(protocol): add proto_broker / oracle_prover addresses into AddressManager in deploy_L1 script Jan 31, 2023
@davidtaikocha davidtaikocha merged commit f3bea40 into main Jan 31, 2023
@davidtaikocha davidtaikocha deleted the update-proto-broker-in-deploy-l1 branch January 31, 2023 15:16
@github-actions github-actions bot mentioned this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants