Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): update PlonkVerifier to accept new public inputs #13208

Merged
merged 7 commits into from
Feb 25, 2023

Conversation

davidtaikocha
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #13208 (2a08af7) into main (4052aad) will decrease coverage by 0.22%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main   #13208      +/-   ##
==========================================
- Coverage   60.99%   60.77%   -0.22%     
==========================================
  Files         115      116       +1     
  Lines        3512     3521       +9     
  Branches      483      483              
==========================================
- Hits         2142     2140       -2     
- Misses       1285     1297      +12     
+ Partials       85       84       -1     
Flag Coverage Δ *Carryforward flag
bridge-ui 93.80% <ø> (ø) Carriedforward from 7ebd6ed
protocol 51.10% <42.85%> (-0.36%) ⬇️
relayer 65.15% <ø> (ø) Carriedforward from 7ebd6ed
ui 100.00% <ø> (ø) Carriedforward from 7ebd6ed

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/libs/LibProving.sol 0.00% <0.00%> (ø)
...ackages/protocol/contracts/libs/LibBlockHeader.sol 92.30% <100.00%> (ø)
packages/protocol/contracts/libs/LibZKP.sol 100.00% <100.00%> (+100.00%) ⬆️
...ckages/protocol/contracts/test/libs/TestLibZKP.sol 100.00% <100.00%> (ø)
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 83.13% <0.00%> (-7.23%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@johntaiko
Copy link

johntaiko commented Feb 23, 2023

Attention: It's not the final version, don't approve

Because the contract of verifier is too large and more than 24kb, so I will optimize the size in next version

@davidtaikocha

This comment was marked as outdated.

dantaik
dantaik previously approved these changes Feb 24, 2023
@dantaik dantaik self-requested a review February 24, 2023 02:51
@davidtaikocha davidtaikocha linked an issue Feb 24, 2023 that may be closed by this pull request
@dantaik dantaik added this pull request to the merge queue Feb 25, 2023
Merged via the queue into main with commit 9804099 Feb 25, 2023
@dantaik dantaik deleted the new-public-input branch February 25, 2023 09:57
@github-actions github-actions bot mentioned this pull request Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(protocol): implement ZKP verifier
3 participants