Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge-ui): update abis #13705

Merged
merged 31 commits into from
May 11, 2023
Merged

fix(bridge-ui): update abis #13705

merged 31 commits into from
May 11, 2023

Conversation

jscriptcoder
Copy link
Contributor

@jscriptcoder jscriptcoder commented May 4, 2023

  • Updated ABIs
  • Using wagmi/cli to copy ABIs from protocol/abi (pnpm export:abi)
    • Generates index.ts exporting ABIs
  • Increase coverage on recommendedProcessingFee

TODO: run exporting ABIs (pnpm export:abi) in the script before copying the json files?

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #13705 (94650cb) into main (801162c) will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #13705      +/-   ##
==========================================
+ Coverage   44.80%   45.00%   +0.19%     
==========================================
  Files         132      130       -2     
  Lines        3535     3520      -15     
  Branches      368      363       -5     
==========================================
  Hits         1584     1584              
+ Misses       1850     1835      -15     
  Partials      101      101              
Flag Coverage Δ *Carryforward flag
bridge-ui 96.00% <100.00%> (+0.39%) ⬆️
eventindexer 82.08% <ø> (ø) Carriedforward from 599ff96
protocol 0.00% <ø> (ø) Carriedforward from 599ff96
relayer 62.55% <ø> (ø) Carriedforward from 599ff96
ui 100.00% <ø> (ø) Carriedforward from 599ff96

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/TaikoL1.sol 0.00% <ø> (ø)
packages/protocol/contracts/L1/TaikoToken.sol 0.00% <ø> (ø)
packages/protocol/contracts/L1/libs/LibProving.sol 0.00% <ø> (ø)
...ckages/protocol/contracts/L1/libs/LibVerifying.sol 0.00% <ø> (ø)
packages/protocol/contracts/L2/TaikoL2.sol 0.00% <ø> (ø)
packages/protocol/contracts/bridge/Bridge.sol 0.00% <ø> (ø)
...ackages/protocol/contracts/bridge/BridgedERC20.sol 0.00% <ø> (ø)
packages/protocol/contracts/bridge/EtherVault.sol 0.00% <ø> (ø)
packages/protocol/contracts/bridge/TokenVault.sol 0.00% <ø> (ø)
...ages/protocol/contracts/common/AddressResolver.sol 0.00% <ø> (ø)
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

dantaik
dantaik previously approved these changes May 5, 2023
dionysuzx
dionysuzx previously approved these changes May 9, 2023
@jscriptcoder jscriptcoder added this pull request to the merge queue May 11, 2023
Merged via the queue into main with commit d3d4e69 May 11, 2023
@jscriptcoder jscriptcoder deleted the update_abis branch May 11, 2023 14:10
@github-actions github-actions bot mentioned this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants