-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bridge-ui): selecting chain was not informing of errors #13712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jscriptcoder
commented
May 5, 2023
•
edited
Loading
edited
- Reusing code to select the chain
- Improving the error handing
- Informing the user when there is a problem switching networks (ChainDropdown was not doing this)
- Installed debug package. I'd like to be able to see logs in production based on a flag. Debug is a very small package with a nice way to visualise logs, which you can namespace filter
Codecov Report
@@ Coverage Diff @@
## main #13712 +/- ##
==========================================
+ Coverage 45.00% 45.37% +0.37%
==========================================
Files 130 132 +2
Lines 3520 3544 +24
Branches 363 365 +2
==========================================
+ Hits 1584 1608 +24
Misses 1835 1835
Partials 101 101
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jscriptcoder
changed the title
fix(bridge-ui): select chain
fix(bridge-ui): selecting chain wasn't informing of errors
May 5, 2023
jscriptcoder
changed the title
fix(bridge-ui): selecting chain wasn't informing of errors
fix(bridge-ui): selecting chain was not informing of errors
May 5, 2023
cyberhorsey
approved these changes
May 11, 2023
dantaik
approved these changes
May 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.