Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(relayer): Out of gas #13778

Merged
merged 3 commits into from
May 18, 2023
Merged

fix(relayer): Out of gas #13778

merged 3 commits into from
May 18, 2023

Conversation

cyberhorsey
Copy link
Contributor

Only check to hardcode gas early if the contract hasnt been deployed, and only check if its not a canonical token to the destination chain.

@cyberhorsey cyberhorsey requested review from dantaik, dionysuzx, adaki2004, davidtaikocha and jscriptcoder and removed request for dantaik and dionysuzx May 17, 2023 19:37
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #13778 (4fd31b7) into main (0615bf6) will decrease coverage by 0.07%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main   #13778      +/-   ##
==========================================
- Coverage   47.24%   47.18%   -0.07%     
==========================================
  Files         131      131              
  Lines        3327     3357      +30     
  Branches      310      310              
==========================================
+ Hits         1572     1584      +12     
- Misses       1656     1670      +14     
- Partials       99      103       +4     
Flag Coverage Δ *Carryforward flag
bridge-ui 96.16% <ø> (ø) Carriedforward from 0615bf6
eventindexer 82.08% <ø> (ø) Carriedforward from 0615bf6
protocol 0.00% <ø> (ø) Carriedforward from 0615bf6
relayer 60.58% <33.33%> (-0.46%) ⬇️
ui 100.00% <ø> (ø) Carriedforward from 0615bf6

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/TaikoL1.sol 0.00% <ø> (ø)
packages/protocol/contracts/L1/libs/LibProving.sol 0.00% <ø> (ø)
packages/protocol/contracts/L1/libs/LibUtils.sol 0.00% <ø> (ø)
...ckages/protocol/contracts/L1/libs/LibVerifying.sol 0.00% <ø> (ø)
...rotocol/contracts/bridge/libs/LibBridgeProcess.sol 0.00% <ø> (ø)
packages/relayer/message/process_message.go 40.65% <33.33%> (-0.33%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidtaikocha davidtaikocha added this pull request to the merge queue May 18, 2023
Merged via the queue into main with commit a42a33b May 18, 2023
@davidtaikocha davidtaikocha deleted the out_of_gas branch May 18, 2023 02:09
@github-actions github-actions bot mentioned this pull request May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants