Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(status-page): updates for a3 #13821

Merged
merged 14 commits into from
May 27, 2023
Merged

feat(status-page): updates for a3 #13821

merged 14 commits into from
May 27, 2023

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented May 26, 2023

  • 8 decimals now, not 18 for tko token. read from contract directly
  • fixes bug in calculating proof time in eventindexer
  • fixes some issues with block indexing in eventindexer
  • add proof time target to status page

stats endpoint returns correct values now:

{
    "id": 1,
    "averageProofTime": 143,
    "averageProofReward": 111418956,
    "numProofs": 741,
    "numVerifiedBlocks": 712
}

keeping in mind we cant index events before today, since the event signature changed.

our current proofTimeTarget is 150, so 143 is on point, and average proof reward for today is a more sensible 1.1 TKO.

Screenshot from 2023-05-26 01-44-45

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #13821 (4b632a1) into main (fa8f195) will decrease coverage by 0.03%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main   #13821      +/-   ##
==========================================
- Coverage   47.41%   47.39%   -0.03%     
==========================================
  Files         133      133              
  Lines        3406     3410       +4     
  Branches      310      310              
==========================================
+ Hits         1615     1616       +1     
- Misses       1682     1685       +3     
  Partials      109      109              
Flag Coverage Δ *Carryforward flag
bridge-ui 96.16% <ø> (ø) Carriedforward from 3f7f390
eventindexer 77.38% <100.00%> (-0.71%) ⬇️
protocol 0.00% <ø> (ø) Carriedforward from 3f7f390
relayer 60.59% <0.00%> (+0.01%) ⬆️
ui 100.00% <ø> (ø) Carriedforward from 3f7f390

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/relayer/indexer/subscribe.go 56.98% <0.00%> (-1.90%) ⬇️
packages/eventindexer/repo/stat.go 57.89% <100.00%> (+1.13%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Co-authored-by: Roger <50648015+RogerLamTd@users.noreply.github.com>
RogerLamTd
RogerLamTd previously approved these changes May 26, 2023
Merged via the queue into main with commit 7ed816d May 27, 2023
@cyberhorsey cyberhorsey deleted the status_updates_a3 branch May 27, 2023 04:20
@github-actions github-actions bot mentioned this pull request May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants