fix(eventindexer): int => string #13828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overall, this Pull Request looks good. Here is some feedback:
- The changes from int to bigint are appropriate.
- There are some repeating variables that should be renamed for clarity. For example, "proofTime" and "proofReward" could be changed to "proofTimeValue" and "proofRewardValue" respectively.
- The variable names should also be more descriptive. For example, "t" in the calcNewAverage function could be changed to "total".
- The code formatting needs to be consistent across the files. For example, the spacing around operators should be consistent.
davidtaikocha
previously approved these changes
May 28, 2023
dantaik
previously approved these changes
May 28, 2023
cyberhorsey
changed the title
Codecov Report
@@ Coverage Diff @@
## main #13828 +/- ##
==========================================
+ Coverage 47.39% 47.45% +0.06%
==========================================
Files 133 133
Lines 3410 3416 +6
Branches 310 310
==========================================
+ Hits 1616 1621 +5
Misses 1685 1685
- Partials 109 110 +1
*This pull request uses carry forward flags. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
davidtaikocha
approved these changes
May 28, 2023
dionysuzx
approved these changes
May 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
int is too small to store stats