feat(status-page): disable L3 on boolean env var #13838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overall, this Pull Request looks good. Here are a few things that you may consider:
- In packages/eventindexer/indexer/save_block_proven_event.go and packages/eventindexer/indexer/save_block_verified_event.go, consider using constants for the log messages instead of concatenating string literals.
- In packages/status-page/.default.env, you may want to add a comment to explain the purpose of the new variable VITE_ENABLE_L3.
- In packages/status-page/src/App.svelte, consider using a ternary operator for the if statement instead of an if block.
- In packages/status-page/src/pages/home/Home.svelte, consider using a guard clause for the toggleLayer function instead of an if statement.
Codecov Report
@@ Coverage Diff @@
## main #13838 +/- ##
==========================================
- Coverage 47.45% 47.39% -0.06%
==========================================
Files 133 133
Lines 3416 3416
Branches 310 310
==========================================
- Hits 1621 1619 -2
- Misses 1685 1687 +2
Partials 110 110
*This pull request uses carry forward flags. Click here to find out more. see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dionysuzx
approved these changes
May 29, 2023
davidtaikocha
approved these changes
May 30, 2023
Merged
dantaik
pushed a commit
that referenced
this pull request
May 31, 2023
dantaik
pushed a commit
that referenced
this pull request
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.