feat(eventindexer): support multiple swap pairs #14130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaikocha
previously approved these changes
Jul 9, 2023
Codecov Report
@@ Coverage Diff @@
## main #14130 +/- ##
==========================================
+ Coverage 50.84% 50.89% +0.05%
==========================================
Files 153 153
Lines 3973 3973
Branches 336 336
==========================================
+ Hits 2020 2022 +2
+ Misses 1842 1840 -2
Partials 111 111
*This pull request uses carry forward flags. Click here to find out more. see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dantaik
approved these changes
Jul 9, 2023
davidtaikocha
approved these changes
Jul 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we were only inedxing one swap pair, but for galaxe, we should actually index TTKO, BLL, and HORSE. and uniswap router cant be watched to emit these evetns, so we should watch all three LP tokens directly.