-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(relayer): Relayer paid gas #14748
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Codecov Report
@@ Coverage Diff @@
## main #14748 +/- ##
==========================================
+ Coverage 39.77% 39.83% +0.05%
==========================================
Files 113 113
Lines 5234 5239 +5
Branches 113 113
==========================================
+ Hits 2082 2087 +5
Misses 3020 3020
Partials 132 132
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cyberhorsey
requested review from
dionysuzx,
davidtaikocha,
dantaik,
RogerLamTd and
adaki2004
September 19, 2023 21:09
RogerLamTd
approved these changes
Sep 19, 2023
dantaik
approved these changes
Sep 20, 2023
KorbinianK
pushed a commit
that referenced
this pull request
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the previous testnets, about 1 in 200 transactions are failing due to running out of gas, but barely. This pad will ensure that the transactions all can be processed, even though the padding amount is overkill for mainnet.
Note that we are not running the relayer in
profitableOnly
mode, a further PR will be incoming to make sure that the total cost is calculated correctly to only process profitable transactions given this padding, which is too large now but ensures all testnet messages will be claimed.