Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(relayer): Relayer paid gas #14748

Merged
merged 5 commits into from
Sep 20, 2023
Merged

fix(relayer): Relayer paid gas #14748

merged 5 commits into from
Sep 20, 2023

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented Sep 19, 2023

As in the previous testnets, about 1 in 200 transactions are failing due to running out of gas, but barely. This pad will ensure that the transactions all can be processed, even though the padding amount is overkill for mainnet.

Note that we are not running the relayer in profitableOnly mode, a further PR will be incoming to make sure that the total cost is calculated correctly to only process profitable transactions given this padding, which is too large now but ensures all testnet messages will be claimed.

@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bridge-ui-v2-a5 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 9:02pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
bridge-ui-v2-internal ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2023 9:02pm

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #14748 (a9baf36) into main (55568df) will increase coverage by 0.05%.
Report is 13 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #14748      +/-   ##
==========================================
+ Coverage   39.77%   39.83%   +0.05%     
==========================================
  Files         113      113              
  Lines        5234     5239       +5     
  Branches      113      113              
==========================================
+ Hits         2082     2087       +5     
  Misses       3020     3020              
  Partials      132      132              
Flag Coverage Δ *Carryforward flag
bridge-ui 93.94% <ø> (ø) Carriedforward from c3895d7
eventindexer 19.38% <ø> (ø) Carriedforward from c3895d7
relayer 42.97% <100.00%> (+0.16%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
packages/relayer/processor/estimate_gas.go 64.70% <100.00%> (+4.70%) ⬆️
packages/relayer/processor/process_message.go 34.47% <100.00%> (+0.61%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik changed the title fix(relayer): Relayer pad gas fix(relayer): Relayer paid gas Sep 20, 2023
@cyberhorsey cyberhorsey added this pull request to the merge queue Sep 20, 2023
Merged via the queue into main with commit b4cb3ff Sep 20, 2023
12 checks passed
@cyberhorsey cyberhorsey deleted the relayer_pad_gas branch September 20, 2023 02:30
@github-actions github-actions bot mentioned this pull request Sep 20, 2023
KorbinianK pushed a commit that referenced this pull request Sep 28, 2023
KorbinianK pushed a commit that referenced this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants