Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bridge-ui-v2): manual NFT import step #14842

Merged
merged 9 commits into from
Oct 6, 2023
Merged

feat(bridge-ui-v2): manual NFT import step #14842

merged 9 commits into from
Oct 6, 2023

Conversation

KorbinianK
Copy link
Contributor

@KorbinianK KorbinianK commented Sep 27, 2023 •
edited
Loading

First "Step" in the NFT bridge - Focus on ERC721

image

Functionality:

  • Validates the entered address
  • Determines NFT contract type
  • Checks ownership of NFTs (via ownerOf for ERC721 and balanceOf for ERC1155)

Open points:
ERC1155 allows for amount input, if the user wants to bridge a mixed number of NFTs with varying amounts, we need to figure out the best way to handle this in the UI. So the ERC1155 code is not finished yet in this step.

@KorbinianK KorbinianK self-assigned this Sep 27, 2023
@vercel
Copy link

vercel bot commented Sep 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bridge-ui-v2-a5 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 2:45pm
bridge-ui-v2-internal ✅ Ready (Inspect) Visit Preview Oct 4, 2023 2:45pm
taiko-mono-bridge-ui-grimsvotn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 2:45pm
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 2:45pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
geth-diff ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2023 2:45pm

@openzeppelin-code
Copy link

openzeppelin-code bot commented Oct 2, 2023 •
edited
Loading

feat(bridge-ui-v2): NFT import step

Generated at commit: f9842455e162d33aab9603bc80c98c2f41f21daa

🚨 Vulnerabilities Summary

Process Issues Results
Contract Inspector note
low
critical
Total		 24
5
1
30
Dependency Checker Total 0

For more details view the full report in OpenZeppelin Code

@KorbinianK
Squashed commit of the following:
9268817 
commit 350e935
Author: Kenk <kenghin_lim@hotmail.com>
Date:   Mon Oct 2 20:27:24 2023 +0700

    feat(website): add AIT Protocol to ecosystem (#14868)

commit 70e3034
Author: Vitalik <95872804+Vitek7373@users.noreply.github.com>
Date:   Sat Sep 30 21:21:47 2023 +0400

    Update prover-market-page.mdx (#14854)

commit d9f4f43
Author: Marcus Wentz <52706599+MarcusWentz@users.noreply.github.com>
Date:   Fri Sep 29 21:40:08 2023 -0400

    docs(website): proposer + prover private key format and status log command to find errors (#14862)

    Co-authored-by: Roger <50648015+RogerLamTd@users.noreply.github.com>

commit f2ba221
Author: Razafindrabe Michaël Maminiaina <razafindrabem2@gmail.com>
Date:   Fri Sep 29 02:57:01 2023 +0300

    chore(docs): add RZF Node to prover list (#14847)

commit 7f4fe71
Author: Ravil Ayupov <35985944+RexCloud@users.noreply.github.com>
Date:   Thu Sep 28 08:14:01 2023 +0500

    docs(website): add prover endpoint to prover market page (#14841)

    Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>

commit b3cd84a
Author: 0xCryptic <145868409+0xCryptic1@users.noreply.github.com>
Date:   Thu Sep 28 08:32:57 2023 +0530

    docs(website): Update enable-a-proposer.mdx with command to check Proposer logs (#14844)

commit db7c31d
Author: broccoin <58350903+broccoin-jp@users.noreply.github.com>
Date:   Thu Sep 28 00:26:00 2023 +0900

    fix(website): Correcting broken link (#14840)

commit 4cfcc42
Author: Kenk <kenghin_lim@hotmail.com>
Date:   Wed Sep 27 09:35:38 2023 +0700

    feat(website): add izar and omnisea to ecosystem page (#14825)

    Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>

commit f4b06db
Author: Kenk <kenghin_lim@hotmail.com>
Date:   Tue Sep 26 21:00:19 2023 +0700

    feat(website): add gourds to ecosystem (#14818)

    Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>

commit e704fc4
Author: moenorman <138952058+moenorman@users.noreply.github.com>
Date:   Tue Sep 26 01:23:32 2023 -0400

    feat(website): add `ZK Nodes` to prover fee market (#14817)

commit 72e0431
Author: Marcus Wentz <52706599+MarcusWentz@users.noreply.github.com>
Date:   Mon Sep 25 22:38:12 2023 -0400

    docs(website): node troubleshooting info: `Skip an invlaid proposed transaction reason="nonce too low`  (#14814)

    Co-authored-by: Daniel Wang <99078276+dantaik@users.noreply.github.com>
    Co-authored-by: Roger <50648015+RogerLamTd@users.noreply.github.com>

commit 73b2944
Author: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>
Date:   Mon Sep 25 22:14:51 2023 +0900

    docs(website): add windows guidance and remove sudo (#14806)

commit 1bc2ea7
Author: Marcus Wentz <52706599+MarcusWentz@users.noreply.github.com>
Date:   Mon Sep 25 09:14:39 2023 -0400

    feat(website): add Alphamint and Xverse to ecosystem (#14807)

commit bf92399
Author: Kenk <kenghin_lim@hotmail.com>
Date:   Mon Oct 2 20:27:24 2023 +0700

    feat(website): add AIT Protocol to ecosystem (#14868)

commit a64ae4e
Author: dave <13951458+d1onys1us@users.noreply.github.com>
Date:   Mon Oct 2 19:28:56 2023 +0900

    feat(website): add link to swap v3 (#14883)

commit 62719e7
Author: Kenk <kenghin_lim@hotmail.com>
Date:   Mon Oct 2 15:09:45 2023 +0700

    feat(website): update TaikoL1 impl address (#14879)

commit d8f40c1
Author: xiaodino <ruby@taiko.xyz>
Date:   Sun Oct 1 21:56:48 2023 -0700

    chore(bridge-ui-v2): Update right top buttons to same UI styles (#14872)

commit 067c86a
Author: pessori55 <108002555+pessori55@users.noreply.github.com>
Date:   Mon Oct 2 00:30:42 2023 +0900

    docs(website): add Sepolia faucet (#14865)

commit ff375f4
Author: Vitalik <95872804+Vitek7373@users.noreply.github.com>
Date:   Sat Sep 30 21:21:47 2023 +0400

    Update prover-market-page.mdx (#14854)

commit 26adcd3
Author: Marcus Wentz <52706599+MarcusWentz@users.noreply.github.com>
Date:   Fri Sep 29 21:40:08 2023 -0400

    docs(website): proposer + prover private key format and status log command to find errors (#14862)

    Co-authored-by: Roger <50648015+RogerLamTd@users.noreply.github.com>

commit e900dd9
Author: Korbinian <KorbinianK@users.noreply.github.com>
Date:   Fri Sep 29 23:14:11 2023 +0200

    chore(bridge-ui-v2): pre-select destination chain (#14850)

    Co-authored-by: David <david@taiko.xyz>

commit 745c196
Author: Kenk <kenghin_lim@hotmail.com>
Date:   Fri Sep 29 22:30:17 2023 +0700

    feat(website): update Bitget on ecosystem page (#14855)

commit 9aec364
Author: Marcus Wentz <52706599+MarcusWentz@users.noreply.github.com>
Date:   Fri Sep 29 00:11:17 2023 -0400

    docs(website): prover proposer danger private key with nextra callout type error + generate isolated burner wallet (#14853)

commit eae3927
Author: Razafindrabe Michaël Maminiaina <razafindrabem2@gmail.com>
Date:   Fri Sep 29 02:57:01 2023 +0300

    chore(docs): add RZF Node to prover list (#14847)

commit 8dd8b61
Author: Korbinian <KorbinianK@users.noreply.github.com>
Date:   Thu Sep 28 05:53:32 2023 +0200

    feat(bridge-ui-v2): NFT bridge stepper (#14811)

commit a61fd72
Author: Ravil Ayupov <35985944+RexCloud@users.noreply.github.com>
Date:   Thu Sep 28 08:14:01 2023 +0500

    docs(website): add prover endpoint to prover market page (#14841)

    Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>

commit fac8f72
Author: 0xCryptic <145868409+0xCryptic1@users.noreply.github.com>
Date:   Thu Sep 28 08:32:57 2023 +0530

    docs(website): Update enable-a-proposer.mdx with command to check Proposer logs (#14844)

commit 7900d8e
Author: broccoin <58350903+broccoin-jp@users.noreply.github.com>
Date:   Thu Sep 28 00:26:00 2023 +0900

    fix(website): Correcting broken link (#14840)

commit 3bc0a45
Author: broccoin <58350903+broccoin-jp@users.noreply.github.com>
Date:   Wed Sep 27 21:36:55 2023 +0900

    fix(website): broken link (#14839)

    Co-authored-by: Daniel Wang <99078276+dantaik@users.noreply.github.com>

commit cf4ebdd
Author: David Cardenas <47157243+davidcardenasus@users.noreply.github.com>
Date:   Wed Sep 27 05:35:01 2023 -0700

    docs(repo): Add YouTube to README (#14833)

    Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>

commit c00a216
Author: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>
Date:   Wed Sep 27 21:33:26 2023 +0900

    docs(website): use remix by default (#14836)

commit 5942326
Author: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>
Date:   Wed Sep 27 15:12:20 2023 +0900

    docs(protocol): add taiko deployment docs and remove bll (#14834)

commit df2e8b9
Author: broccoin <58350903+broccoin-jp@users.noreply.github.com>
Date:   Wed Sep 27 11:39:28 2023 +0900

    docs(website): update node-runner-manual "how to compare .env and .env.sample" (#14831)

    Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>

commit e7c66a3
Author: Kenk <kenghin_lim@hotmail.com>
Date:   Wed Sep 27 09:36:05 2023 +0700

    feat(website): add proof market video (#14824)

    Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>

commit be216d0
Author: Kenk <kenghin_lim@hotmail.com>
Date:   Wed Sep 27 09:35:38 2023 +0700

    feat(website): add izar and omnisea to ecosystem page (#14825)

    Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>

commit cb9c779
Author: Kenk <kenghin_lim@hotmail.com>
Date:   Tue Sep 26 21:00:19 2023 +0700

    feat(website): add gourds to ecosystem (#14818)

    Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>

commit 1405121
Author: moenorman <138952058+moenorman@users.noreply.github.com>
Date:   Tue Sep 26 01:23:32 2023 -0400

    feat(website): add `ZK Nodes` to prover fee market (#14817)

commit 23f5bf6
Author: Marcus Wentz <52706599+MarcusWentz@users.noreply.github.com>
Date:   Mon Sep 25 22:38:12 2023 -0400

    docs(website): node troubleshooting info: `Skip an invlaid proposed transaction reason="nonce too low`  (#14814)

    Co-authored-by: Daniel Wang <99078276+dantaik@users.noreply.github.com>
    Co-authored-by: Roger <50648015+RogerLamTd@users.noreply.github.com>

commit cde533c
Author: Marcus Wentz <52706599+MarcusWentz@users.noreply.github.com>
Date:   Mon Sep 25 22:13:06 2023 -0400

    docs(website): update FAQ `Does Taiko have a sequencer?` (#14812)

commit a67c495
Author: D <51912515+adaki2004@users.noreply.github.com>
Date:   Tue Sep 26 04:00:13 2023 +0200

    fix(protocol): Fix genesis tests (#14813)

commit 833b4f5
Author: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>
Date:   Mon Sep 25 22:15:22 2023 +0900

    chore(repo): update add_project issue template (#14805)

commit df7be21
Author: Kenk <kenghin_lim@hotmail.com>
Date:   Mon Sep 25 20:15:12 2023 +0700

    feat(website): add uniswap v3 addresses (#14804)

    Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>

commit 7367f01
Author: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>
Date:   Mon Sep 25 22:14:51 2023 +0900

    docs(website): add windows guidance and remove sudo (#14806)

commit e23c267
Author: Marcus Wentz <52706599+MarcusWentz@users.noreply.github.com>
Date:   Mon Sep 25 09:14:39 2023 -0400

    feat(website): add Alphamint and Xverse to ecosystem (#14807)

commit 23636c7
Author: Korbinian <korbiniank@outlook.de>
Date:   Mon Oct 2 16:09:49 2023 +0200

    bridgetabs sizes

commit 7fa506c
Author: Korbinian <korbiniank@outlook.de>
Date:   Wed Sep 27 17:01:06 2023 +0200

    import steps, validating ownership etc

commit 0bf4d78
Author: Korbinian <korbiniank@outlook.de>
Date:   Wed Sep 27 16:57:33 2023 +0200

    i18n

commit 02fac48
Author: Korbinian Kasberger <korbi@taiko.xyz>
Date:   Wed Sep 27 09:20:32 2023 +0200

    basic layout

commit e56a890
Author: Korbinian Kasberger <korbi@taiko.xyz>
Date:   Mon Sep 25 17:04:05 2023 +0200

    fix button size

commit 7616048
Author: Korbinian Kasberger <korbi@taiko.xyz>
Date:   Mon Sep 25 16:55:17 2023 +0200

     basic dynamic stepper

commit b9281d7
Author: Korbinian Kasberger <korbi@taiko.xyz>
Date:   Mon Sep 25 16:54:39 2023 +0200

    add bridgetypes, tabs to store
@KorbinianK KorbinianK force-pushed the feat/bridge-ui-v2--nft-import-step branch from 350e935 to 9268817 Compare October 2, 2023 14:41
@KorbinianK KorbinianK marked this pull request as ready for review October 4, 2023 14:41
@KorbinianK KorbinianK changed the title feat(bridge-ui-v2): NFT import step feat(bridge-ui-v2): manual NFT import step Oct 5, 2023
@davidtaikocha davidtaikocha added this pull request to the merge queue Oct 6, 2023
Merged via the queue into main with commit c85e162 Oct 6, 2023
14 checks passed
@davidtaikocha davidtaikocha deleted the feat/bridge-ui-v2--nft-import-step branch October 6, 2023 10:18
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
Merged
dionysuzx pushed a commit that referenced this pull request Oct 16, 2023
@KorbinianK @dionysuzx
feat(bridge-ui-v2): manual NFT import step (#14842)
031f007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaodino xiaodino xiaodino approved these changes

@dantaik dantaik dantaik approved these changes

@dionysuzx dionysuzx Awaiting requested review from dionysuzx

@cyberhorsey cyberhorsey Awaiting requested review from cyberhorsey

Assignees

@KorbinianK KorbinianK

Labels
area.bridge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KorbinianK @dantaik @xiaodino @davidtaikocha