Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): adopt optimism new trie codebase #15608

Merged
merged 11 commits into from
Jan 31, 2024
Merged

feat(protocol): adopt optimism new trie codebase #15608

merged 11 commits into from
Jan 31, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jan 30, 2024

From Brecht:

We may want to update the Merkle trie/RLP decoding to the latest versions used in optimism: https://github.com/ethereum-optimism/optimism/tree/develop/packages/contracts-bedrock/src/libraries. I haven't diffed them, but seems likely there are also some optimizations in there. In any case, we should definitely check if the new versions contain fixes or improvements.

@dantaik dantaik requested review from dionysuzx and Brechtpd January 30, 2024 04:57
@dantaik dantaik requested review from adaki2004 and davidtaikocha and removed request for dionysuzx January 30, 2024 04:58
@dantaik dantaik marked this pull request as ready for review January 30, 2024 04:58
@vercel Vercel
Copy link

vercel bot commented Jan 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
bridge-ui-v2-a6 ✅ Ready (Inspect) Visit Preview Jan 30, 2024 2:35pm

@dantaik dantaik requested a review from adaki2004 January 30, 2024 07:03
@dantaik dantaik requested a review from adaki2004 January 30, 2024 14:01
@dantaik dantaik enabled auto-merge January 30, 2024 14:33
@dantaik dantaik added this pull request to the merge queue Jan 31, 2024
Merged via the queue into alpha-6 with commit f5e7ee1 Jan 31, 2024
14 checks passed
@dantaik dantaik deleted the adopt_optimism_new_trie_code branch January 31, 2024 01:10
This was referenced Feb 9, 2024
Closed
Merged
@taiko-kitty taiko-kitty mentioned this pull request Mar 1, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request Mar 29, 2024
Closed
This was referenced Apr 5, 2024
Closed
Closed
@taiko-kitty taiko-kitty mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@adaki2004 adaki2004 adaki2004 approved these changes

@Brechtpd Brechtpd Brechtpd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dantaik @Brechtpd @adaki2004 @davidtaikocha