feat(protocol): get rid of new compiler warnings

[dantaik]

undone the implementation() function

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
bridge-ui-v2-a6	✅ Ready (Inspect)	Visit Preview	Jan 30, 2024 3:08pm

[dantaik]

I'm trying to figure out :

[Brechtpd]

Should be possible already using eth_getstorageat as explained in the comments: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/61117c4db8497ba489d5e1e127565a011ed6907a/contracts/proxy/ERC1967/ERC1967Proxy.sol#L33

I assume the reason not to expose it directly onchain is to lower the cost of deploying the proxy contract because public functions require extra opcodes. Even though in this case the deployment cost isn't really that important, seems like the method to get the implementation contract is already easy.

[dantaik]

Should be possible already using eth_getstorageat as explained in the comments: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/61117c4db8497ba489d5e1e127565a011ed6907a/contracts/proxy/ERC1967/ERC1967Proxy.sol#L33

I assume the reason not to expose it directly onchain is to lower the cost of deploying the proxy contract because public functions require extra opcodes. Even though in this case the deployment cost isn't really that important, seems like the method to get the implementation contract is already easy.

With this approach, the dapp/client side then has no way of reading the impl to customize some logics then.

[dantaik]

I'm trying to figure out :

I have to make this change to get rid of the compiler warnings: f36f5ab

Any idea?