Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nfts): taikoon-ui design r4 #17423

Merged
merged 89 commits into from
Jun 3, 2024
Merged

fix(nfts): taikoon-ui design r4 #17423

merged 89 commits into from
Jun 3, 2024

Conversation

bearni95
Copy link
Contributor

@bearni95 bearni95 commented May 29, 2024

Important: DO NOT MERGE

This PR has the following PRs merged into it, and requires those to be merged before this one:


  • correct button colors
  • correct "Mint now" icon color on light mode
  • Resize buttons on mobile menu
  • Gallery component component overlap on mobile
  • Hide hardhat network on final deployment
  • Network enforcer update
  • cleanup non-ui file changes
  • use svg logo
  • remove pre-mint warning modal
  • FAQ content
  • holesky deployment
  • endless load on mint panel
  • remove snap scrolling
  • fix footer overlapping FAQs on short screens

  • add network-enforcer exception for *.vercel.app*

Notion QA

  • gas fee bug
  • console outputs on mint page
  • toasts using wrong colors
  • web3 modal lists hardhat
  • header buttons have no states
  • collection page empty
  • error thrown on "Your taikoons" page
  • indicate when it's "your collection" vs an address on collection page title
  • header cna overlap wallet (medium screen)
  • cannot re-open already clicked taikoon on collection page
  • cache ipfs details
  • pre-mint modal needs to be improved
    • add proper link to chain explorer
  • FAQ text improvement
  • More story/text/background
  • No traits visible
  • Report when user has already minted on eligibility page

  • update mint panel after wallet disconnect

QA Round 2

  • Network enforcer broken on vercel
  • Mint page flickers upon load
  • Include a check case for the mint modal saying "Sorry, you are not eligible"
  • Hide "Your Taikoons" menu button as long as the user has none minted
  • No ENS Name warning on "Your collection"
  • Handle collection load states
  • Metamask not available on mobile
  • Glassy header not visible on mobile
  • System not detecting metamask wallet switches
  • Collection on mobile pops a "#NaN" detail view of a Taikoon upon load

QA Round 3

  • broken owner link in collection detail
  • memory leak

Copy link

openzeppelin-code bot commented May 30, 2024

fix(nfts): taikoon-ui design r4

Generated at commit: 8a722fa70dfb915fb64165b7fd2ea12c2feac955

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
8
42
54
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@bearni95 bearni95 marked this pull request as ready for review May 31, 2024 15:30
@KorbinianK KorbinianK added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 4cf0739 Jun 3, 2024
6 checks passed
@KorbinianK KorbinianK deleted the taikoon-ui-design-r4 branch June 3, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants