Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): rework footer links formatting #371

Merged
merged 4 commits into from
Dec 5, 2022

Conversation

wolfderechter
Copy link
Contributor

Rework footer links formatting regarding issue #349

@wolfderechter wolfderechter changed the title Rework footer links formatting fix(website): rework footer links formatting Dec 1, 2022
dantaik
dantaik previously approved these changes Dec 2, 2022
@dionysuzx
Copy link
Collaborator

dionysuzx commented Dec 2, 2022

before (landscape):
image
after (landscape):
image

@wolfderechter i noticed that this caused the dots to be un-centered now in the normal landscape view. the mobile looks fine though

@wolfderechter
Copy link
Contributor Author

@d1onys1us you are correct, I have missed that initially. Fixed it now

@dionysuzx
Copy link
Collaborator

@d1onys1us you are correct, I have missed that initially. Fixed it now

thank you. i also notice now that the dots are shifted up from center as well.

prev:
image
after:
image

@wolfderechter
Copy link
Contributor Author

Ahh the devil is in the detail! Okay should be all good now

@dantaik dantaik enabled auto-merge (squash) December 5, 2022 14:23
@dantaik dantaik merged commit c62bbe5 into taikoxyz:main Dec 5, 2022
@dionysuzx
Copy link
Collaborator

@all-contributors please add @wolfderechter code,doc

@allcontributors
Copy link
Contributor

@d1onys1us

I've put up a pull request to add @wolfderechter! 🎉

@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants